-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving active span interaction To Trace Context Utilities #923
Merged
yurishkuro
merged 13 commits into
open-telemetry:master
from
toumorokoshi:feature/context-interaction-from-contextmanager
Sep 24, 2020
Merged
Moving active span interaction To Trace Context Utilities #923
yurishkuro
merged 13 commits into
open-telemetry:master
from
toumorokoshi:feature/context-interaction-from-contextmanager
Sep 24, 2020
Commits on Sep 6, 2020
-
Moving active span interaction To TracerProvider
Fixes open-telemetry#455. The previous spec stated that the active span get / set behavior MUST behave the same across Tracers retrieved from the same TracerProvider. As such, the active span manipulation methods are better provided by the TracerProvider directly. As it is still cumbersome to retrieve the current TracerProvider simply to get the current span, add in the concept of a "Trace Package", that can provide utilty methods to delegate to the configured default TracerProvider. This enables a fluid interface to retrieve the current span: from opentelemetry import trace current_span = trace.get_current_span() To help maintain backwards compatibility, the Tracer may still expose active span methods.
Configuration menu - View commit details
-
Copy full SHA for 5f70f81 - Browse repository at this point
Copy the full SHA 5f70f81View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd9d8a2 - Browse repository at this point
Copy the full SHA dd9d8a2View commit details
Commits on Sep 7, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e2b6e02 - Browse repository at this point
Copy the full SHA e2b6e02View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c76928 - Browse repository at this point
Copy the full SHA 0c76928View commit details
Commits on Sep 9, 2020
-
Merge remote-tracking branch 'source/master' into feature/context-int…
…eraction-from-contextmanager
Configuration menu - View commit details
-
Copy full SHA for f692cdd - Browse repository at this point
Copy the full SHA f692cddView commit details -
Removing the get / set current span methods from the TracerProvider. There is consensus that the functions should have the same behavior regardless of the TracerProvider. This change now means that the span retrieval methods can not be defined completely by the Trace Package. Moving the requirements up to the package level.
Configuration menu - View commit details
-
Copy full SHA for b9e9305 - Browse repository at this point
Copy the full SHA b9e9305View commit details
Commits on Sep 11, 2020
-
Selecting "Tracing Context Utilities" rather than "Trace Package" to provide clear guidance on languages that do not have static module-level functions. Adding a section on the ability to expose these as module-level functions to ensure that the simplified workflow of a top-level get / set span is possible.
Configuration menu - View commit details
-
Copy full SHA for 1897bf3 - Browse repository at this point
Copy the full SHA 1897bf3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 760ae7f - Browse repository at this point
Copy the full SHA 760ae7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for bebaf44 - Browse repository at this point
Copy the full SHA bebaf44View commit details
Commits on Sep 13, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 0ba8658 - Browse repository at this point
Copy the full SHA 0ba8658View commit details -
Configuration menu - View commit details
-
Copy full SHA for 117c30b - Browse repository at this point
Copy the full SHA 117c30bView commit details
Commits on Sep 18, 2020
-
Configuration menu - View commit details
-
Copy full SHA for b1ed693 - Browse repository at this point
Copy the full SHA b1ed693View commit details
Commits on Sep 23, 2020
-
Configuration menu - View commit details
-
Copy full SHA for c351dce - Browse repository at this point
Copy the full SHA c351dceView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.