Skip to content

Conversation

@majanjua-amzn
Copy link

@majanjua-amzn majanjua-amzn commented Oct 22, 2025

Fixes #4698

Changes

Adds the spec for a new AlwaysRecord sampler being proposed in #4698

Notes

Solutions to this problem in multiple supported languages can already be found below:

Checklist

Copy link
Contributor

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. As we discussed in Sampling SIG, it will help readers to be reminded somewhere in this text that Exporters are already expected to drop these spans, all we're doing is making it easy to setup non-sampling recorded spans by default.

@majanjua-amzn majanjua-amzn marked this pull request as ready for review October 28, 2025 17:04
@majanjua-amzn majanjua-amzn requested review from a team as code owners October 28, 2025 17:04
@majanjua-amzn
Copy link
Author

Apologies for the delay, pushed a new revision. Please help to run the workflows again, thanks!

@majanjua-amzn
Copy link
Author

Perhaps @jmacd could you help to merge? Thanks

@carlosalberto
Copy link
Contributor

Ping @majanjua-amzn (we need a last few details to iron out, but very close to merge this).

@majanjua-amzn
Copy link
Author

@carlosalberto, could you help to run the workflows again and approve if all looks good now? Thanks

@majanjua-amzn
Copy link
Author

Question in general: Should these be added to the core or contrib repo? For example:

@majanjua-amzn majanjua-amzn force-pushed the main branch 2 times, most recently from 3a01a76 to 497fea4 Compare November 26, 2025 17:54
@majanjua-amzn
Copy link
Author

@cijothomas finished another revision, please take a look when you can

Also, if anyone has input on the previous comment regarding where to add this feature, please advise:

Question in general: Should these be added to the core or contrib repo? For example:

@majanjua-amzn majanjua-amzn force-pushed the main branch 2 times, most recently from a9e1387 to 4fdc8c7 Compare November 26, 2025 20:12
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I suggest to request re-reviews from previous approvers, given that the wordings have changed a lot since initial version.

@majanjua-amzn
Copy link
Author

Great, made a final revision with respect to the last comment.

If reviewers could re-approve if all looks good and merge this PR, I can also start finalizing my PRs to each other repo and start contributing the feature to OTel core!

Thanks in advance

@majanjua-amzn
Copy link
Author

Perhaps @jmacd and @carlosalberto can help provide reviews again, as you folks were early reviewers the first time?

PRs are awaiting the merge of this one in Java, Python, JS, and .NET:

Java: open-telemetry/opentelemetry-java#7877
Python: open-telemetry/opentelemetry-python#4823
JS: open-telemetry/opentelemetry-js#6168
.NET: open-telemetry/opentelemetry-dotnet#6732

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Always process spans / AlwaysRecord Sampler

7 participants