-
Notifications
You must be signed in to change notification settings - Fork 935
Add spec for AlwaysRecord sampler #4699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
jmacd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. As we discussed in Sampling SIG, it will help readers to be reminded somewhere in this text that Exporters are already expected to drop these spans, all we're doing is making it easy to setup non-sampling recorded spans by default.
|
Apologies for the delay, pushed a new revision. Please help to run the workflows again, thanks! |
|
Perhaps @jmacd could you help to merge? Thanks |
|
Ping @majanjua-amzn (we need a last few details to iron out, but very close to merge this). |
|
@carlosalberto, could you help to run the workflows again and approve if all looks good now? Thanks |
|
Question in general: Should these be added to the core or contrib repo? For example:
|
3a01a76 to
497fea4
Compare
|
@cijothomas finished another revision, please take a look when you can Also, if anyone has input on the previous comment regarding where to add this feature, please advise:
|
a9e1387 to
4fdc8c7
Compare
cijothomas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I suggest to request re-reviews from previous approvers, given that the wordings have changed a lot since initial version.
|
Great, made a final revision with respect to the last comment. If reviewers could re-approve if all looks good and merge this PR, I can also start finalizing my PRs to each other repo and start contributing the feature to OTel core! Thanks in advance |
|
Perhaps @jmacd and @carlosalberto can help provide reviews again, as you folks were early reviewers the first time? PRs are awaiting the merge of this one in Java, Python, JS, and .NET: Java: open-telemetry/opentelemetry-java#7877 |
Fixes #4698
Changes
Adds the spec for a new AlwaysRecord sampler being proposed in #4698
Notes
Solutions to this problem in multiple supported languages can already be found below:
Checklist
CHANGELOG.mdfile updated for non-trivial changes