Named meter namespace clarification #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Wolfgang Ziegler <wolfgang.ziegler@dynatrace.com>
dyladan
requested review from
AloisReitbauer,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
jmacd,
reyang,
SergeyKanzhelev,
songy23,
tedsuo,
tigrannajaryan and
yurishkuro
as code owners
yurishkuro
reviewed
Jan 14, 2020
c24t
reviewed
Jan 14, 2020
bogdandrutu
approved these changes
Jan 16, 2020
AloisReitbauer
approved these changes
Jan 21, 2020
arminru
approved these changes
Jan 21, 2020
jmacd
approved these changes
Jan 21, 2020
Oberon00
approved these changes
Jan 22, 2020
carlosalberto
approved these changes
Jan 22, 2020
SergeyKanzhelev
pushed a commit
to SergeyKanzhelev/opentelemetry-specification
that referenced
this pull request
Feb 18, 2020
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clarifies some wording which conflated the terms namespace and Meter Name.It has been decided that Meter name is indeed to be used as the namespace, so this PR simply clarifies the wording surrounding that. It also adds back the Meter creation section which was originally introduced by @z1c0 in #264 and removed in #250.This addresses issue #391