Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move attribute documents to semantic-conventions repository #3758

Merged
merged 3 commits into from
Nov 24, 2023

Conversation

jack-berg
Copy link
Member

@jack-berg jack-berg commented Nov 7, 2023

Related to #3746.

Leaving as a draft until corresponding open-telemetry/semantic-conventions#493 is merged.

open-telemetry/semantic-conventions#493 has been merged and this is ready for review.

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This builds fine (in conjunction with open-telemetry/semantic-conventions#493) on the OTel website side (FYI).

@jack-berg jack-berg marked this pull request as ready for review November 16, 2023 20:58
@jack-berg jack-berg requested review from a team November 16, 2023 20:58
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 24, 2023
@arminru arminru merged commit 6f24488 into open-telemetry:main Nov 24, 2023
7 checks passed
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
…emetry#3758)

Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants