-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OTEL_SERVICE_VERSION environment variable. #3573
Add OTEL_SERVICE_VERSION environment variable. #3573
Conversation
@carlosalberto would you update the changelog? |
I feel like this is not nearly as important as OTEL_SERVICE_NAME. If the generic resource environment variable is too cumbersome to use, maybe we should address that instead of introducing more special cases. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
I'd argue it has some value as it brings completeness to the Resource's service section. IMHO it's not a big change neither. Let's discuss the pros and cons in the Spec call next Tuesday. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Adding my 2 cents... With the complexities of modern deployments, I think it's very helpful for users to understand which version of their app generated the signals they are observing and be able to distinguish data in a partial deployment. Telling users to put it in the resource map suggests that it's more optional and probably not useful. Can we please move forward with this proposal? |
Agree with @Oberon00 - redundancy is not good, and making this part of the spec creates a bunch of work in the SDK SIGs for a capability that is already available, only for the sake of making it "more visible". Instead we can make improvements in the documentation, recommending people to set a version. |
@yurishkuro I agree with it in general, but we already do this massaging for Maybe @pellared @MikeGoldsmith want to chime in? I remember interest in this specific value. |
I think that |
I would rather consider something more generic like #3025. However, I do not see a not of interest in both issues. Therefore, I think the best think is to not change anything at the moment. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
As service.version was recently marked as stable, we should (IMHO) add an environment variable for it (there's a moratorium on environment variables but this should be allowed, as it complements the existing
OTEL_SERVICE_NAME
variable).Btw, we still reference our copy of the semantic conventions, and we should update such links.