Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JVM gc duration unit and bucket boundaries #3458

Merged
merged 3 commits into from
May 3, 2023
Merged

JVM gc duration unit and bucket boundaries #3458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94697a5
Use seconds for jvm gc duration
jack-berg Apr 28, 2023
f08244c
Changelog entry
jack-berg Apr 28, 2023
f861d32
Merge branch 'main' into gc-duration-unit
reyang May 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ release.

- Add experimental histogram advice API.
([#3216](https://github.com/open-telemetry/opentelemetry-specification/pull/3216))
- Specify second unit (`s`) and advice bucket boundaries of `[]`
for `process.runtime.jvm.gc.duration`.
([#3458](https://github.com/open-telemetry/opentelemetry-specification/pull/3458))

### Logs

Expand Down
2 changes: 1 addition & 1 deletion semantic_conventions/metrics/process-runtime-jvm-metrics.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ groups:
metric_name: process.runtime.jvm.gc.duration
brief: "Duration of JVM garbage collection actions."
instrument: histogram
unit: "ms"
unit: "s"
attributes:
- id: gc
type: string
Expand Down
6 changes: 5 additions & 1 deletion specification/metrics/semantic_conventions/runtime-environment-metrics.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,10 +209,14 @@ This metric is [recommended](../metric-requirement-level.md#recommended).

This metric is [recommended](../metric-requirement-level.md#recommended).

This metric SHOULD be specified with
[`ExplicitBucketBoundaries`](../../metrics/api.md#instrument-advice)
of `[]` (single bucket histogram capturing count, sum, min, max).

<!-- semconv metric.process.runtime.jvm.gc.duration(metric_table) -->
| Name | Instrument Type | Unit (UCUM) | Description |
| -------- | --------------- | ----------- | -------------- |
| `process.runtime.jvm.gc.duration` | Histogram | `ms` | Duration of JVM garbage collection actions. |
| `process.runtime.jvm.gc.duration` | Histogram | `s` | Duration of JVM garbage collection actions. |
<!-- endsemconv -->

<!-- semconv metric.process.runtime.jvm.gc.duration(full) -->
Expand Down