Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that attribute requirement levels apply to instrumentation libraries #3289

Merged
merged 8 commits into from
Mar 16, 2023
Merged

Clarify that attribute requirement levels apply to instrumentation libraries #3289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7bcec8f
Attribute requirement levels apply to instrumentation
trask Mar 3, 2023
c2c85f8
Add change log entry
trask Mar 3, 2023
2cb144c
Update specification/common/attribute-requirement-level.md
trask Mar 6, 2023
55fa01e
Merge remote-tracking branch 'upstream/main' into attr-req-levels-app…
trask Mar 7, 2023
29b881a
Update specification/common/attribute-requirement-level.md
trask Mar 8, 2023
937d896
Merge branch 'main' into attr-req-levels-apply-to-instrumentation
trask Mar 8, 2023
764af41
Update CHANGELOG.md
trask Mar 8, 2023
2626f17
Merge branch 'main' into attr-req-levels-apply-to-instrumentation
bogdandrutu Mar 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ release.

### Semantic Conventions

- Clarify that attribute requirement levels apply to the instrumentation library
([#3289](https://github.com/open-telemetry/opentelemetry-specification/pull/3289))
- Fix grammatical number of metric units.
([#3298](https://github.com/open-telemetry/opentelemetry-specification/pull/3298))
- Rename `net.app.protocol.(name|version)` to `net.protocol.(name|version)`
Expand Down
2 changes: 2 additions & 0 deletions specification/common/attribute-requirement-level.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@

_This section applies to Log, Metric, Resource, and Span, and describes requirement levels for attributes defined in semantic conventions._

Attribute requirement levels apply to the [instrumentation library](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/glossary.md#instrumentation-library).

The following attribute requirement levels are specified:

- [Required](#required)
Expand Down