Rename faas.execution to faas.invocation_id and change units for faas.max_memory
#3209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As decided in the FAAS SIG, the previous term was too generic. Also updated various documentation to better align with this terminology.
For better unit consistency with other the semantic conventions.
carlosalberto
approved these changes
Feb 15, 2023
lmolkova
approved these changes
Feb 15, 2023
(assuming this is released in the next minor version)
|
Also @tylerbenson can you add a Changelog entry? Thanks! |
|
Oh also, please start the entry with "BREAKING" (so hopefully users/maintainers will know sooner than later, etc) |
arminru
added
area:semantic-conventions
Aneurysm9
reviewed
Feb 16, 2023
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
tylerbenson
changed the title
faas.execution to faas.invocation_id and change units for faas.max_memory
|
@Aneurysm9 Does this look correct? |
Aneurysm9
approved these changes
Feb 17, 2023
jsuereth
pushed a commit
to jsuereth/opentelemetry-specification
that referenced
this pull request
Feb 28, 2023
…`faas.max_memory` (open-telemetry#3209)
This was referenced Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out from #3188
Changes
faas.executiontofaas.invocation_idfaas.max_memoryunits to Bytes instead of MB