Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move specification for implementations of the metric API into own specification #3171

Merged
merged 24 commits into from
Feb 14, 2023
Merged

Move specification for implementations of the metric API into own specification #3171

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
dc018df
Add the initial draft of the metric No-Op
MrAlias Jan 24, 2023
bdd82fb
Give overview of SDK
MrAlias Jan 24, 2023
e2b62b6
Move API spec of MeterProvider creation to SDK
MrAlias Jan 24, 2023
ee4bfd7
Merge branch 'main' into noop-metric
MrAlias Jan 30, 2023
343eabe
Move SDK spec for meter out of API
MrAlias Feb 2, 2023
2e22500
Merge branch 'main' into noop-metric
MrAlias Feb 2, 2023
c356980
Use consistent emphasis style
MrAlias Feb 2, 2023
6c83c87
Fix toc addition from merge
MrAlias Feb 2, 2023
3213e5a
Generate toc for noop.md
MrAlias Feb 2, 2023
fb27024
Remove API req to treat empty unit/desc as ""
MrAlias Feb 2, 2023
640d3a6
Merge branch 'main' into noop-metric
MrAlias Feb 6, 2023
0a76c8b
Merge branch 'main' into noop-metric
MrAlias Feb 6, 2023
16f1656
Merge branch 'main' into noop-metric
MrAlias Feb 7, 2023
7a841d2
Merge branch 'main' into noop-metric
MrAlias Feb 9, 2023
71e52f2
Apply suggestions from code review
MrAlias Feb 9, 2023
a04838a
Update Meter Creation from code review
MrAlias Feb 9, 2023
aee8049
Link info on instrument identifying fields
MrAlias Feb 9, 2023
77d0d96
Merge branch 'main' into noop-metric
MrAlias Feb 9, 2023
ff3968f
Fix singular possessive
MrAlias Feb 9, 2023
e17384d
Apply suggestions from code review
MrAlias Feb 13, 2023
815f59f
Merge branch 'main' into noop-metric
MrAlias Feb 13, 2023
cb73f45
Require all language impls to provide a No-Op
MrAlias Feb 13, 2023
befae32
Remove SDK mention from unit/desc treatment
MrAlias Feb 14, 2023
ffa3e3f
Merge branch 'main' into noop-metric
MrAlias Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move API spec of MeterProvider creation to SDK
  • Loading branch information
@MrAlias
MrAlias committed Jan 24, 2023
commit e2b62b6af5c00b031e5dc49de5826ad5cbcf79ae
6 changes: 0 additions & 6 deletions specification/metrics/api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,12 +105,6 @@ Normally, the `MeterProvider` is expected to be accessed from a central place.
Thus, the API SHOULD provide a way to set/register and access a global default
`MeterProvider`.

Notwithstanding any global `MeterProvider`, some applications may want to or
have to use multiple `MeterProvider` instances, e.g. to have different
configuration for each, or because its easier with dependency injection
frameworks. Thus, implementations of `MeterProvider` SHOULD allow creating an
arbitrary number of `MeterProvider` instances.

### MeterProvider operations

The `MeterProvider` MUST provide the following functions:
Expand Down
2 changes: 2 additions & 0 deletions specification/metrics/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ metrics produced by any `Meter` from the `MeterProvider`. The [tracing SDK
specification](../trace/sdk.md#additional-span-interfaces) has provided some
suggestions regarding how to implement this efficiently.

The SDK SHOULD allow the creation of multiple independent `MeterProvider`s.

### Meter Creation

New `Meter` instances are always created through a `MeterProvider`
Expand Down