Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to http span name #3165

Merged
merged 3 commits into from
Feb 3, 2023
Merged

Changes to http span name #3165

merged 3 commits into from
Feb 3, 2023

Conversation

trask
Copy link
Member

@trask trask commented Feb 1, 2023

Fixes #2998

Changes

Changes http server span names from

  • {http.route} to {http.method} {http.route} (when route is available)
  • HTTP {http.method} to {http.method} (when route is not available)

Changes http client span names from

  • HTTP {http.method} to {http.method}

@trask trask marked this pull request as ready for review February 2, 2023 17:45
@trask trask requested review from a team February 2, 2023 17:45
@trask trask added area:semantic-conventions Related to semantic conventions semconv:HTTP labels Feb 2, 2023
@arminru arminru added the spec:trace Related to the specification/trace directory label Feb 3, 2023
@Oberon00
Copy link
Member

HTTP {http.method} to {http.method} (when route is not available)

What was the rationale for this?

@trask
Copy link
Member Author

trask commented Jul 18, 2023

What was the rationale for this?

this was done to make the span name consistent between the cases where http.route is available and is not available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions semconv:HTTP spec:trace Related to the specification/trace directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Span name for http server spans should include http.method.
9 participants