-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify guidance regarding excessive logging #3151
Merged
reyang
merged 5 commits into
open-telemetry:main
from
alanwest:alanwest/excessive-logging
Feb 4, 2023
Merged
Clarify guidance regarding excessive logging #3151
reyang
merged 5 commits into
open-telemetry:main
from
alanwest:alanwest/excessive-logging
Feb 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
approved these changes
Jan 27, 2023
tigrannajaryan
approved these changes
Jan 27, 2023
djaglowski
approved these changes
Jan 27, 2023
cijothomas
approved these changes
Jan 27, 2023
carlosalberto
approved these changes
Jan 27, 2023
Let's mention this in the maintainers meeting next Monday, so this is not a surprise, etc. |
Good point. I think this also requires a changelog entry. |
arminru
added
area:sdk
Related to the SDK
area:error-reporting
Related to error reporting
labels
Jan 31, 2023
arminru
approved these changes
Jan 31, 2023
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3147
Clarifies guidance with regards to logging when items (attributes, span links/events) are dropped or truncated on spans or log records.
I'm not certain what was originally intended to be communicated, so my initial proposal is to state that a message must only be printed once per Span/LogRecord regardless of how many items were dropped or truncated on the Span/LogRecord. However, some may argue this too may lead to excessive logging.
So the real question is what do we want to communicate here?
Another option may be to state something like: