Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify usage of log body for structured logs #3023

Merged
merged 8 commits into from
Jan 3, 2023
Merged

Clarify usage of log body for structured logs #3023

merged 8 commits into from
Jan 3, 2023

Conversation

djaglowski
Copy link
Member

See decision by Log SIG noted in #3014

@djaglowski djaglowski requested review from a team December 7, 2022 19:08
@djaglowski djaglowski force-pushed the structured-log-body-clarification branch from b5132ea to 5612b9e Compare December 7, 2022 19:21
@djaglowski
Copy link
Member Author

@open-telemetry/specs-logs-approvers, please take a look.

MrAlias
MrAlias reviewed Dec 8, 2022
View reviewed changes
specification/logs/data-model.md Show resolved Hide resolved
specification/logs/data-model.md Outdated Show resolved Hide resolved
djaglowski
djaglowski commented Dec 8, 2022
View reviewed changes
specification/logs/data-model.md Outdated Show resolved Hide resolved
specification/logs/data-model.md Show resolved Hide resolved
specification/logs/data-model.md Show resolved Hide resolved
specification/logs/data-model.md Outdated Show resolved Hide resolved
@djaglowski
Copy link
Member Author

@open-telemetry/specs-approvers, please take a look

@arminru arminru added spec:logs Related to the specification/logs directory area:data-model For issues related to data model labels Dec 13, 2022
@jack-berg
Copy link
Member

Please add changelog entry. Thanks!

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 22, 2022
@djaglowski djaglowski removed the Stale label Dec 23, 2022
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 31, 2022
@djaglowski djaglowski removed the Stale label Dec 31, 2022
@tigrannajaryan tigrannajaryan merged commit 619551a into open-telemetry:main Jan 3, 2023
@djaglowski djaglowski deleted the structured-log-body-clarification branch January 3, 2023 17:42
@djaglowski djaglowski mentioned this pull request Jun 23, 2023
Closed
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@djaglowski
Clarify usage of log body for structured logs (open-telemetry#3023)
38b6b4b 
See decision by Log SIG noted in [open-telemetry#3014](open-telemetry#3014 (comment))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias left review comments

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@jack-berg jack-berg jack-berg approved these changes

Assignees

@SergeyKanzhelev SergeyKanzhelev

Labels
area:data-model For issues related to data model spec:logs Related to the specification/logs directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@djaglowski @jack-berg @tigrannajaryan @MrAlias @arminru @SergeyKanzhelev