Explicitly allow fail-fast for invalid enum values #2766
+3
−1
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,7 +21,9 @@ If an SDK chooses to support an integer-valued environment variable, it SHOULD s | |
| ### Enum value | ||
|
|
||
| For variables which accept a known value out of a set, i.e., an enum value, SDK implementations MAY support additional values not listed here. | ||
| For variables accepting an enum value, if the user provides a value the SDK does not recognize, | ||
| the SDK MUST generate a warning and gracefully ignore the setting, | ||
| or _fail fast_ and cause the application to fail at startup, but MUST NOT cause the application to fail later at run time. | ||
pellared marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. I don't think this change is necessary - #2817 (comment) |
||
|
|
||
| If a null object (empty, no-op) value is acceptable, then the enum value representing it MUST be `"none"`. | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure why this behavior is only under Enum values, shouldn't there be a common error behavior for all env values? What if integer var is set to
blah?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about it as well, but I want to avoid scope creep in this PR. Even right now it is not clear how to proceed