Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Prometheus Sums for handling delta counter case #2570

Merged
merged 7 commits into from
May 26, 2022

Conversation

locmai
Copy link
Contributor

@locmai locmai commented May 21, 2022

Update for the corner cases of delta counters when being converted to cumulative sum in open-telemetry/opentelemetry-collector-contrib#9919

Changes

  • Update the expected behaviors of the new data point.
  • Add the options to correct/report for the single-write principle violation issue in the delta-to-cumulative guide.

Related issues:

Signed-off-by: Loc Mai <locmai0201@gmail.com>
Signed-off-by: Loc Mai <locmai0201@gmail.com>
@locmai locmai requested review from a team May 21, 2022 09:49
@reyang reyang added spec:metrics Related to the specification/metrics directory area:data-model For issues related to data model labels May 21, 2022
Signed-off-by: Loc Mai <locmai0201@gmail.com>
@reyang reyang merged commit db6afbc into open-telemetry:main May 26, 2022
beeme1mr pushed a commit to beeme1mr/opentelemetry-specification that referenced this pull request Aug 31, 2022
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:data-model For issues related to data model spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants