Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rpc.system value for Apache Dubbo #2453

Merged
merged 3 commits into from
Mar 30, 2022
Merged

Add rpc.system value for Apache Dubbo #2453

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e82906
Add rpc.system value for Apache Dubbo
trask Mar 29, 2022
3582268
Generate table
trask Mar 29, 2022
eeabbd6
Merge remote-tracking branch 'upstream/main' into add-apache-dubbo-rp…
trask Mar 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Generate table
  • Loading branch information
@trask
trask committed Mar 29, 2022
commit 3582268431ffc81992a86fbe14d58f0489c7996e
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ release.
- Add semantic conventions for [CloudEvents](https://cloudevents.io).
([#1978](https://github.com/open-telemetry/opentelemetry-specification/pull/1978))
- Add `rpc.system` value for Apache Dubbo.
([#9999](https://github.com/open-telemetry/opentelemetry-specification/pull/9999))
([#2453](https://github.com/open-telemetry/opentelemetry-specification/pull/2453))

### Compatibility

Expand Down
1 change: 1 addition & 0 deletions specification/metrics/semantic_conventions/rpc.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ or not they should be on the server, client or both.
| `grpc` | gRPC |
| `java_rmi` | Java RMI |
| `dotnet_wcf` | .NET WCF |
| `apache_dubbo` | Apache Dubbo |
<!-- endsemconv -->

To avoid high cardinality, implementations should prefer the most stable of `net.peer.name` or
Expand Down
1 change: 1 addition & 0 deletions specification/trace/semantic_conventions/rpc.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ Examples of span names:
| `grpc` | gRPC |
| `java_rmi` | Java RMI |
| `dotnet_wcf` | .NET WCF |
| `apache_dubbo` | Apache Dubbo |
<!-- endsemconv -->

For client-side spans `net.peer.port` is required if the connection is IP-based and the port is available (it describes the server port they are connecting to).
Expand Down