Default push metric exporters to use a periodic metric reader #2379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
added
spec:metrics
bogdandrutu
approved these changes
Mar 1, 2022
cijothomas
reviewed
Mar 1, 2022
jack-berg
approved these changes
Mar 2, 2022
|
Folks during the 3/1 spec SIG meeting agreed that defaulting to using a periodic metric reader for push based is fine. Though, there was some additional discussion for defaulting the Since this PR already has some approvals, I can follow up with another PR suggesting a shorter interval for stdout. |
cijothomas
approved these changes
Mar 2, 2022
reyang
added
the
release:allowed-for-ga
codeboten
approved these changes
Mar 8, 2022
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…elemetry#2379) * Default push metric exporters to use a periodic metric reader * Default push metric exporters to use a periodic metric reader * Make link relative * Update changelog Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least two SDKs differ in whether they default to using the periodic MetricReader when automatically configuring which exporter to use. This PR proposes that SDKs should default to using the periodic MetricReader when configuring the use of the stdout, in-memory, and OTLP exporters.
Java
The autoconfigure module allows users to configure the use of either the OTLP or logging (stdout) exporter. The exporter is paired with a periodic MetricReader.
https://github.com/open-telemetry/opentelemetry-java/blob/083dca1b94c6e803579311e008848aa6b80d921b/sdk-extensions/autoconfigure/src/main/java/io/opentelemetry/sdk/autoconfigure/MetricExporterConfiguration.java#L44-L67
.NET
Users can programmatically add an exporter without explicitly declaring the MetricReader to use. The exporter is not paired with a periodic MetricReader by default and requires
ForceFlushto be called on the MeterProvider. However, you can configure it to use the periodic MetricReader.https://github.com/open-telemetry/opentelemetry-dotnet/blob/644ba5bc14eac8919032cb27a958d1fa919a8b37/examples/AspNetCore/Startup.cs#L137-L145
This PR is related to #2378. If #2378 is not accepted - that is, it is intended that all push metric exporters always be paired with a periodic exporting MetricReader, then this PR is probably unnecessary.