Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RFC SHOULD NOT wording in histogram aggregation #2164

Merged
merged 4 commits into from
Jan 10, 2022
Merged

Use RFC SHOULD NOT wording in histogram aggregation #2164

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1710b99
Use RFC SHOULD NOT wording in histogram aggregation
anuraaga Nov 24, 2021
593eb18
Merge branch 'main' into should-not
arminru Jan 7, 2022
d89de97
Fix merge conflict
arminru Jan 7, 2022
72daa2f
Merge branch 'main' into should-not
carlosalberto Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions specification/metrics/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,22 +386,20 @@ This Aggregation honors the following configuration parameters:
| Boundaries | double\[\] | [ 0, 5, 10, 25, 50, 75, 100, 250, 500, 1000 ] | Array of increasing values representing explicit bucket boundary values.<br><br>The Default Value represents the following buckets:<br>(-&infin;, 0], (0, 5.0], (5.0, 10.0], (10.0, 25.0], (25.0, 50.0], (50.0, 75.0], (75.0, 100.0], (100.0, 250.0], (250.0, 500.0], (500.0, 1000.0], (1000.0, +&infin;) |
| RecordMinMax | true, false | true | Whether to record min and max. |

Note: This aggregator should not fill out `sum` when used with instruments
that record negative measurements, e.g. `UpDownCounter` or `ObservableGauge`.

This Aggregation informs the SDK to collect:

- Count of `Measurement` values falling within explicit bucket boundaries.
- Arithmetic sum of `Measurement` values in population.
- Arithmetic sum of `Measurement` values in population. This SHOULD NOT be collected when used with
jmacd marked this conversation as resolved.
Show resolved Hide resolved
instruments that record negative measurements, e.g. `UpDownCounter` or `ObservableGauge`.
- Min (optional) `Measurement` value in population.
- Max (optional) `Measurement` value in population.

## Attribute limits

Attributes which belong to Metrics are exempt from the
[common rules of attribute limits](../common/common.md#attribute-limits) at this
time. Attribute truncation or deletion could affect identitity of metric time
series and it requires further analysis.
time. Attribute truncation or deletion could affect identity of metric time
series and the topic requires further analysis.
jmacd marked this conversation as resolved.
Show resolved Hide resolved

## Exemplar

Expand Down