-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Syslog severity number mapping in the example #2091
Merged
bogdandrutu
merged 4 commits into
open-telemetry:main
from
tigrannajaryan:feature/tigran/syslogmapping
Nov 4, 2021
Merged
Fix Syslog severity number mapping in the example #2091
bogdandrutu
merged 4 commits into
open-telemetry:main
from
tigrannajaryan:feature/tigran/syslogmapping
Nov 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emergency and Alert were incorrectly ordered (Emergency is was less severe but it is actually more severe in Syslog). This fixes the mapping. Fixes open-telemetry#2042
tigrannajaryan
force-pushed
the
feature/tigran/syslogmapping
branch
from
November 2, 2021 01:16
a8da037
to
f7be77a
Compare
kumoroku
approved these changes
Nov 2, 2021
djaglowski
approved these changes
Nov 2, 2021
zenmoto
approved these changes
Nov 3, 2021
docfx action is not feeling well, unclear what the problem is. |
kumoroku
approved these changes
Nov 4, 2021
We have 2 approvals which supposedly should be enough but I still can't merge. Let's get one more approval if possible. |
bogdandrutu
approved these changes
Nov 4, 2021
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Emergency and Alert were incorrectly ordered (Emergency is was less severe but it is actually more severe in Syslog). This fixes the mapping. Fixes open-telemetry#2042 Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emergency and Alert were incorrectly ordered (Emergency is was
less severe but it is actually more severe in Syslog).
This fixes the mapping.
Fixes #2042