Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify metrics SDK limits handling #2007

Merged
merged 11 commits into from
Oct 15, 2021
Merged

Clarify metrics SDK limits handling #2007

merged 11 commits into from
Oct 15, 2021

Conversation

reyang
Copy link
Member

@reyang reyang commented Oct 11, 2021

Fixes #1936.

@reyang reyang requested review from a team October 11, 2021 17:09
@reyang reyang added the area:sdk Related to the SDK label Oct 11, 2021
@reyang reyang added this to the Metrics API/SDK Feature Freeze milestone Oct 11, 2021
@reyang reyang added the spec:metrics Related to the specification/metrics directory label Oct 11, 2021
arminru
arminru reviewed Oct 12, 2021
View reviewed changes
specification/metrics/sdk.md Outdated Show resolved Hide resolved
specification/metrics/sdk.md Outdated Show resolved Hide resolved
specification/metrics/sdk.md Outdated Show resolved Hide resolved
specification/metrics/sdk.md Outdated Show resolved Hide resolved
specification/metrics/sdk.md Outdated Show resolved Hide resolved
reyang and others added 5 commits October 12, 2021 09:18
@reyang @arminru
Update specification/metrics/sdk.md
65e8cc3 
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
@reyang @arminru
Update specification/metrics/sdk.md
c8d297b 
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
@reyang @arminru
Apply suggestions from code review
1404b06 
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
@reyang
lowercase
5da4a4a
@reyang
Merge branch 'main' into reyang/metrics-sdk-limits
41836a9
jsuereth
jsuereth approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, pending Armin's comments being resolved.

arminru
arminru approved these changes Oct 13, 2021
View reviewed changes
specification/metrics/sdk.md Show resolved Hide resolved
@jmacd jmacd enabled auto-merge (squash) October 15, 2021 17:27
@jmacd jmacd merged commit 512c344 into open-telemetry:main Oct 15, 2021
@reyang reyang mentioned this pull request Oct 15, 2021
Closed
@reyang reyang deleted the reyang/metrics-sdk-limits branch October 18, 2021 18:59
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@reyang @arminru
Clarify metrics SDK limits handling (open-telemetry#2007)
79cee63 
* Clarify metrics SDK limits handling

* fix link

* Update specification/metrics/sdk.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* Update specification/metrics/sdk.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* Apply suggestions from code review

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* lowercase

* update changelog

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmacd jmacd jmacd approved these changes

@jsuereth jsuereth jsuereth approved these changes

@arminru arminru arminru approved these changes

Assignees

@carlosalberto carlosalberto

Labels
area:sdk Related to the SDK spec:metrics Related to the specification/metrics directory
Projects
None yet
Milestone
Metrics API/SDK Feature Freeze
Development

Successfully merging this pull request may close these issues.

Call out the behavior of Inf and NaN values for the metrics API
5 participants
@reyang @jsuereth @jmacd @arminru @carlosalberto