Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize span creation #190

Merged
merged 18 commits into from
Aug 6, 2019
Merged

Generalize span creation #190

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
ef2480e
Revise span creation, scrub references to builder
c24t Jul 22, 2019
6bd22e6
Make it clear that root spans aren't optional
c24t Jul 22, 2019
cae98f6
Move attrs, reword multiple sections
c24t Jul 23, 2019
e8d1dea
Lose StartSpan
c24t Jul 23, 2019
391857d
s/spans/span/
c24t Jul 23, 2019
a036be3
Hard wrap edits
c24t Jul 23, 2019
ed16890
Hard wrap rest of file
c24t Jul 23, 2019
7e9984f
Update active span description for PR comments
c24t Jul 23, 2019
2742bc7
Note that span attrs are ordered
c24t Jul 23, 2019
a4a8e38
Summarize span config, add details
c24t Jul 23, 2019
203a691
Apply @arminru's suggestions from code review
c24t Jul 24, 2019
3e6444a
Merge branch 'master' into span-creation-prose
c24t Jul 24, 2019
d2cebe9
Add notes on attribute, event, link ordering
c24t Jul 24, 2019
2e1af8e
Clarify optional/required span fields
c24t Jul 25, 2019
9271e1b
Merge branch 'master' into span-creation-prose
c24t Jul 25, 2019
0dc27c4
Remove attribute ordering note
c24t Jul 25, 2019
90e8366
Merge branch 'master' into span-creation-prose
yurishkuro Jul 30, 2019
d397b38
Merge branch 'master' into span-creation-prose
carlosalberto Aug 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into span-creation-prose
  • Loading branch information
@c24t
c24t committed Jul 25, 2019
commit 9271e1b6315fc135d6f076cda6eeffeabd6a70d0

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.