-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a few typos in the datamodel specification #1716
Fix a few typos in the datamodel specification #1716
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I think pointing to proto@v0.9.0 is fine to have stable references, let's see what the @open-telemetry/specs-metrics-approvers say.
I think referring to a specific version is a safer approach. If we point to main and it changes we need to update the references anyway. If updating the references is a requirement to keep the spec correct then I would rather link to specific versions and ensure it is never broken, just maybe outdated if a newer version is released (which I think is less bad). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Changes