Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write description for Gauge metric type in DataModel Specification #1661

Merged
merged 12 commits into from
May 11, 2021

Conversation

jsuereth
Copy link
Contributor

@jsuereth jsuereth commented Apr 29, 2021

Adds a description of Gauge in the data model specification.

@jsuereth jsuereth marked this pull request as ready for review April 29, 2021 16:39
@jsuereth jsuereth requested review from a team April 29, 2021 16:39
specification/metrics/datamodel.md Outdated Show resolved Hide resolved
specification/metrics/datamodel.md Outdated Show resolved Hide resolved
jsuereth and others added 2 commits April 29, 2021 12:55
Co-authored-by: Punya Biswal <punya@google.com>
Co-authored-by: Punya Biswal <punya@google.com>
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@kenfinnigan kenfinnigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsuereth

@arminru arminru added area:data-model For issues related to data model spec:metrics Related to the specification/metrics directory labels May 6, 2021
@jmacd jmacd merged commit 38d1430 into open-telemetry:main May 11, 2021
@jsuereth jsuereth deleted the wip-gauge branch February 8, 2024 17:39
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
…pen-telemetry#1661)

* Write description for Gauge metric type.

* update changelog with PR

* Crop image.

* Update specification/metrics/datamodel.md

Co-authored-by: Punya Biswal <punya@google.com>

* Update specification/metrics/datamodel.md

Co-authored-by: Punya Biswal <punya@google.com>

* Fixes from review.

* Fix merge conflict issue.

* Fixes from review.

Co-authored-by: Punya Biswal <punya@google.com>
Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:data-model For issues related to data model spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants