-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write description for Gauge metric type in DataModel Specification #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
punya
reviewed
Apr 29, 2021
Co-authored-by: Punya Biswal <punya@google.com>
Co-authored-by: Punya Biswal <punya@google.com>
kjordy
reviewed
Apr 29, 2021
Oberon00
reviewed
Apr 30, 2021
kenfinnigan
reviewed
Apr 30, 2021
reyang
approved these changes
Apr 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
jmacd
approved these changes
May 1, 2021
kenfinnigan
approved these changes
May 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jsuereth
ebullient
approved these changes
May 3, 2021
ebullient
approved these changes
May 4, 2021
arminru
added
area:data-model
For issues related to data model
spec:metrics
Related to the specification/metrics directory
labels
May 6, 2021
bogdandrutu
reviewed
May 11, 2021
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…pen-telemetry#1661) * Write description for Gauge metric type. * update changelog with PR * Crop image. * Update specification/metrics/datamodel.md Co-authored-by: Punya Biswal <punya@google.com> * Update specification/metrics/datamodel.md Co-authored-by: Punya Biswal <punya@google.com> * Fixes from review. * Fix merge conflict issue. * Fixes from review. Co-authored-by: Punya Biswal <punya@google.com> Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:data-model
For issues related to data model
spec:metrics
Related to the specification/metrics directory
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a description of Gauge in the data model specification.