Go implementation of SpanContext does not confirm with w3c #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
arminru
approved these changes
Feb 10, 2021
carlosalberto
approved these changes
Feb 10, 2021
Oberon00
reviewed
Feb 10, 2021
| @@ -27,7 +27,7 @@ status of the feature is not known. | |||
| | [SpanContext](specification/trace/api.md#spancontext) | | | | | | | | | | | | | | |||
| | IsValid | | + | + | + | + | + | + | + | + | + | + | + | | |||
| | IsRemote | | - | + | + | + | + | + | + | + | + | + | + | | |||
| | Conforms to the W3C TraceContext spec | | + | + | + | + | + | + | | + | + | + | + | | |||
| | Conforms to the W3C TraceContext spec | | | + | + | + | + | + | | + | + | + | + | | |||
There was a problem hiding this comment.
Shouldn't this be a - instead of empty cell?
There was a problem hiding this comment.
I can do that :) I tried to be a bit more friendly :))
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…metry#1421) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See open-telemetry/opentelemetry-go#1515