Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run "Auto Assign" workflow once draft PRs are ready for review #1138

Merged
merged 1 commit into from
Oct 23, 2020
Merged

Run "Auto Assign" workflow once draft PRs are ready for review #1138

merged 1 commit into from
Oct 23, 2020

Conversation

arminru
Copy link
Member

@arminru arminru commented Oct 23, 2020

@arminru arminru requested review from a team October 23, 2020 15:02
@arminru arminru mentioned this pull request Oct 23, 2020
Merged
anuraaga
anuraaga approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bogdandrutu
Copy link
Member

@arminru can we keep only the "ready_for_review"?

@arminru
Copy link
Member Author

arminru commented Oct 23, 2020

@bogdandrutu I'm not sure if the event is only triggered for PRs that transition from draft to ready or also for ones that are created as ready already, the documentation is a bit sparse. We could try but I don't see an issue with having both (unless it ends up assigning two users at once).

@bogdandrutu bogdandrutu merged commit 87b9d57 into open-telemetry:master Oct 23, 2020
@arminru arminru deleted the fix-auto-assign branch October 23, 2020 18:10
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@arminru
Run "Auto Assign" workflow once draft PRs are ready for review (open-…
ec255cb 
…telemetry#1138)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@Oberon00 Oberon00 Oberon00 approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

@anuraaga anuraaga anuraaga approved these changes

Assignees

@tigrannajaryan tigrannajaryan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@arminru @bogdandrutu @anuraaga @carlosalberto @Oberon00 @tigrannajaryan