Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove semantic convention for http.status_text #950

Closed
iNikem opened this issue Sep 15, 2020 · 4 comments · Fixed by #972
Closed

Remove semantic convention for http.status_text #950

iNikem opened this issue Sep 15, 2020 · 4 comments · Fixed by #972
Assignees
Labels
area:semantic-conventions Related to semantic conventions release:after-ga Not required before GA release, and not going to work on before GA spec:trace Related to the specification/trace directory

Comments

@iNikem
Copy link
Contributor

iNikem commented Sep 15, 2020

HTTP semantic convention defines http.status_text as HTTP reason phrase. But even RFC sounds like that reason phrase is an obsolete artefact (emphasis is mine):

The reason-phrase element exists for the sole purpose of providing a
textual description associated with the numeric status code, mostly
out of deference to earlier Internet application
protocols that were
more frequently used with interactive text clients. A client SHOULD
ignore
the reason-phrase content

Should we drop this semantic attribute as serving no actual purpose?

@iNikem iNikem added the spec:trace Related to the specification/trace directory label Sep 15, 2020
@Oberon00
Copy link
Member

We inherited this attribute from OpenCensus AFAIK. But if the RFC says it SHOULD be ignored then I think there would be a point in doing so. I think it also does not exist from HTTP 2 on.

We could also consider marking the attribute as deprecated (should not be set by instrumentation, but if you get it, this is the meaning).

@Oberon00 Oberon00 added the area:semantic-conventions Related to semantic conventions label Sep 15, 2020
@carlosalberto
Copy link
Contributor

We could also consider marking the attribute as deprecated (should not be set by instrumentation, but if you get it, this is the meaning).

I'd rather remove it (unless OC really needs it for backwards compatibility).

@andrewhsu andrewhsu added the release:after-ga Not required before GA release, and not going to work on before GA label Sep 15, 2020
@bogdandrutu
Copy link
Member

+1 to remove this

@arminru
Copy link
Member

arminru commented Sep 18, 2020

Done in #972.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions release:after-ga Not required before GA release, and not going to work on before GA spec:trace Related to the specification/trace directory
Projects
None yet
6 participants