Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete span attributes #2089

Open
dyladan opened this issue Apr 8, 2021 · 3 comments
Open

Remove obsolete span attributes #2089

dyladan opened this issue Apr 8, 2021 · 3 comments
Labels
signal:traces Issues and PRs related to general traces signal stale

Comments

@dyladan
Copy link
Member

dyladan commented Apr 8, 2021

Most of these sound like obsolete attributes that are represented/named differently

  • grpc.kind should be represented as the Span Kind
  • grpc.status_code should be rpc.grpc.status_code
  • grpc.error_name is redundant with the code
  • gprc.status_message is probably worth filing a spec PR for (as rpc.grpc.status_message). The span status message might not be ideal to use for it, for the same reason we don't mark spans as failed in RecordException.
  • http.status_text was deemed useless and removed without replacement, see Remove semantic convention for http.status_text opentelemetry-specification#950.
  • http.error_name, http.status_text: No idea what these are.

Originally posted by @Oberon00 in #2083 (comment)

@github-actions
Copy link

github-actions bot commented Aug 1, 2022

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Aug 1, 2022
@legendecas legendecas removed the stale label Aug 2, 2022
@legendecas
Copy link
Member

grpc.kind is removed in #3127.

@legendecas legendecas added the signal:traces Issues and PRs related to general traces signal label Sep 1, 2022
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
signal:traces Issues and PRs related to general traces signal stale
Projects
None yet
Development

No branches or pull requests

2 participants