-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No clear API defined for resource detector libraries #4016
Labels
spec:resource
Related to the specification/resource directory
triage:accepted:ready
Ready to be implemented. Small enough or uncontroversial enough to be implemented without sponsor
Comments
joaopgrassi
added
the
spec:resource
Related to the specification/resource directory
label
Apr 26, 2024
For Go it is |
danielgblanco
added
the
triage:deciding:community-feedback
Open to community discussion. If the community can provide sufficient reasoning, it may be accepted
label
Apr 29, 2024
austinlparker
added
triage:accepted:ready
Ready to be implemented. Small enough or uncontroversial enough to be implemented without sponsor
and removed
triage:deciding:community-feedback
Open to community discussion. If the community can provide sufficient reasoning, it may be accepted
labels
Jul 23, 2024
A PR to clarify this would be welcome! |
For java its ResourceProvider. Detectors that implement this interface are able to contribute to the resource generated by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
spec:resource
Related to the specification/resource directory
triage:accepted:ready
Ready to be implemented. Small enough or uncontroversial enough to be implemented without sponsor
What are you trying to achieve?
We have specified the way to load resource attributes from the environment via resource detector packages.
The Resource SDK spec says:
But it never defined exactly what the method is called. This may end up in a situation where each library exposes a method with a different name which then creates problems if such packages are to be loaded/invoked automatically (e.g., by an agent). This would make implementing something like #2948 impossible.
What did you expect to see?
Clear specification of what a resource detector package must provide, giving which method it must have, similar to what we do for Samplers for example.
The text was updated successfully, but these errors were encountered: