Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema transformations should be able to convert metric units #3729

Open
pyohannes opened this issue Oct 19, 2023 · 2 comments
Open

Schema transformations should be able to convert metric units #3729

pyohannes opened this issue Oct 19, 2023 · 2 comments
Assignees
Labels
spec:miscellaneous For issues that don't match any other spec label triage:deciding:community-feedback Open to community discussion. If the community can provide sufficient reasoning, it may be accepted

Comments

@pyohannes
Copy link
Contributor

What are you trying to achieve?

Recently the default unit for duration metrics was changed from milliseconds to seconds. This resulted (and will result) in breaking changes to existing metrics semantic conventions. Some related PRs/issues:

This change could be covered by automatic schema transformations by specifying the metric name, the old unit, the new unit, and a conversion factor.

Such a schema transformation would help telemetry consumers to mitigate the pain of such breaking changes, as data points from a metric from different versions of semantic conventions with different units could be aggregated into the same metric. This can help avoid severe disruptions for telemetry consumers.

Furthermore, the possibility of covering such changes by schema transformations gives more flexibility to semantic conventions authors, as without such a mechanism changing units for stable metrics would be impossible.

@tigrannajaryan
Copy link
Member

I support this. Any transformation that we notice happens often in semconv and is possible to process in a stateless manner by just looking at an individual metric data point should be a candidate for becoming a supported transform in the Schema file.

@tigrannajaryan
Copy link
Member

We need more community feedback and use cases to decide on the priority of this.

@tigrannajaryan tigrannajaryan added triage:deciding:community-feedback Open to community discussion. If the community can provide sufficient reasoning, it may be accepted triage:deciding:needs-info Not enough information. Left open to provide the author with time to add more details and removed triage:deciding:needs-info Not enough information. Left open to provide the author with time to add more details labels Apr 19, 2024
@github-actions github-actions bot added the triage:followup Needs follow up during triage label Sep 19, 2024
@trask trask removed the triage:followup Needs follow up during triage label Sep 24, 2024
@github-actions github-actions bot added the triage:followup Needs follow up during triage label Sep 25, 2024
@trask trask removed the triage:followup Needs follow up during triage label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:miscellaneous For issues that don't match any other spec label triage:deciding:community-feedback Open to community discussion. If the community can provide sufficient reasoning, it may be accepted
Projects
None yet
Development

No branches or pull requests

4 participants