Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus spec: Should it be possible to disable target_info #3702

Closed
rapphil opened this issue Sep 21, 2023 · 2 comments · Fixed by #3872
Closed

Prometheus spec: Should it be possible to disable target_info #3702

rapphil opened this issue Sep 21, 2023 · 2 comments · Fixed by #3872
Assignees
@jmacd
Labels
spec:metrics Related to the specification/metrics directory

Comments

@rapphil
Copy link

rapphil commented Sep 21, 2023

What are you trying to achieve?
Similarly to how it is possible for otel_scope_info, I think the prometheus spec should explicitly mention that exporter can have a configuration option to disable the target_info metric.

In fact, the prometheus remote write exporter already has this option coded.

For the sake of consistency I believe that the specification should include the following line in the end of this section:

Prometheus exporters SHOULD provide a configuration option to disable the
`target_info` metrics.

What did you expect to see?

I would like that the spec explicitly mention that exporter can provide a configuration option to disable the target_info metric.

Additional context.

Add any other context about the problem here. If you followed an existing documentation, please share the link to it.
@rapphil rapphil added the spec:metrics Related to the specification/metrics directory label Sep 21, 2023
@rapphil
Copy link
Author

rapphil commented Sep 21, 2023

@open-telemetry/wg-prometheus

@dashpole
Copy link
Contributor

I support this change

@dashpole dashpole mentioned this issue Oct 25, 2023
Open
@dashpole dashpole mentioned this issue Feb 8, 2024
Merged
carlosalberto pushed a commit that referenced this issue Mar 27, 2024
@dashpole
Prometheus SDK exporter specification cleanups (#3872)
98e1344 
Fixes
#3702
Fixes
#2468

Addresses
#3737 (comment)

## Changes

* Add option to disable `target` info metric.
* Move SDK-specific language from the compatibility spec to the
prometheus exporter spec.
* Disallow using OpenMetrics proto format, or Prometheus remote write
formats in SDK exporters
* Recommend using Prometheus client libraries
* Clarify that only features supported by the text format are required
to be implemented by Prometheus exporters
* Require prometheus SDK exporters to follow the compatibility
specification.

@open-telemetry/wg-prometheus
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this issue Oct 31, 2024
@dashpole
Prometheus SDK exporter specification cleanups (open-telemetry#3872)
d5d6459 
Fixes
open-telemetry#3702
Fixes
open-telemetry#2468

Addresses
open-telemetry#3737 (comment)

## Changes

* Add option to disable `target` info metric.
* Move SDK-specific language from the compatibility spec to the
prometheus exporter spec.
* Disallow using OpenMetrics proto format, or Prometheus remote write
formats in SDK exporters
* Recommend using Prometheus client libraries
* Clarify that only features supported by the text format are required
to be implemented by Prometheus exporters
* Require prometheus SDK exporters to follow the compatibility
specification.

@open-telemetry/wg-prometheus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmacd jmacd

Labels
spec:metrics Related to the specification/metrics directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prometheus SDK exporter specification cleanups dashpole/opentelemetry-specification
3 participants
@dashpole @jmacd @rapphil