-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new required attributes is a breaking change #3283
Comments
We discussed a proposal in the WG meeting Friday to remove Required attributes, replacing them with Conditionally Required, where "Conditionally Required without condition" means instrumentation from this specification version onward must provide it. I'm wondering if this is needed after the clarification in #3289. I think "Required" now means "instrumentation for this specification version must provide it", and the schema stability rules govern how that can (or cannot) change in future specification versions. |
I'm fine closing this and considering it's addressed with #3289 |
…braries (#3289) Based on discussion in semconv stability WG Closes #3283 ## Changes Clarifies that attribute requirement levels apply to instrumentation. And that, because users can transform their telemetry in a number of ways (e.g. metric views, span processors, and collector transformations), these requirement levels cannot be relied on by telemetry consumers. --------- Co-authored-by: Liudmila Molkova <limolkova@microsoft.com> Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
…braries (open-telemetry#3289) Based on discussion in semconv stability WG Closes open-telemetry#3283 ## Changes Clarifies that attribute requirement levels apply to instrumentation. And that, because users can transform their telemetry in a number of ways (e.g. metric views, span processors, and collector transformations), these requirement levels cannot be relied on by telemetry consumers. --------- Co-authored-by: Liudmila Molkova <limolkova@microsoft.com> Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
Discussion: #3225 (comment)
Adding new required attributes cannot be handled with schema transformation and would require a major schema version update.
However, spec allows it:
opentelemetry-specification/specification/versioning-and-stability.md
Lines 230 to 236 in e2b9fe0
The text was updated successfully, but these errors were encountered: