Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expand the declaration of pool.name in the spec #3038

Closed
haddasbronfman opened this issue Dec 15, 2022 · 0 comments · Fixed by #3050
Closed

expand the declaration of pool.name in the spec #3038

haddasbronfman opened this issue Dec 15, 2022 · 0 comments · Fixed by #3050
Assignees
@jsuereth
Labels
area:semantic-conventions Related to semantic conventions semconv:database spec:metrics Related to the specification/metrics directory

Comments

@haddasbronfman
Copy link
Member

In issue #2958 we talked about the lack of pool name in MySQL (JS) which can be used as the value for attribute pool.name.
This led us to use another pool.name that is built from the data we have about the pool: host: localhost port: 3306 database: db_test user: root.

I think we should add it to the spec and declare that if the pool has no name in the DB we are working on, then it will be built like the format above.
@haddasbronfman haddasbronfman added the spec:metrics Related to the specification/metrics directory label Dec 15, 2022
@arminru arminru added area:semantic-conventions Related to semantic conventions semconv:database labels Dec 15, 2022
haddasbronfman added a commit to haddasbronfman/opentelemetry-specification that referenced this issue Dec 20, 2022
@haddasbronfman
Update database-metrics.md
0176743 
according to the discussion here: open-telemetry#3038 I'm updating the `pool.name attribute`
@haddasbronfman haddasbronfman mentioned this issue Dec 20, 2022
Merged
@arminru arminru linked a pull request Dec 20, 2022 that will close this issue
Expand pool.name in semantic conventions #3050
Merged
carlosalberto pushed a commit that referenced this issue Mar 3, 2023
@haddasbronfman
Expand pool.name in semantic conventions (#3050)
66f8c4c 
according to the discussion here:
#3038
I'm updating the `pool.name attribute`
jsuereth pushed a commit to jsuereth/otel-semconv-test that referenced this issue Apr 19, 2023
@haddasbronfman
Expand pool.name in semantic conventions (#3050)
ef9a24c 
according to the discussion here:
open-telemetry/opentelemetry-specification#3038
I'm updating the `pool.name attribute`
jsuereth pushed a commit to open-telemetry/semantic-conventions that referenced this issue May 11, 2023
@haddasbronfman
Expand pool.name in semantic conventions (#3050)
c7c60ca 
according to the discussion here:
open-telemetry/opentelemetry-specification#3038
I'm updating the `pool.name attribute`
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this issue Oct 31, 2024
@haddasbronfman
Expand pool.name in semantic conventions (open-telemetry#3050)
505fd9e 
according to the discussion here:
open-telemetry#3038
I'm updating the `pool.name attribute`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsuereth jsuereth

Labels
area:semantic-conventions Related to semantic conventions semconv:database spec:metrics Related to the specification/metrics directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expand pool.name in semantic conventions haddasbronfman/opentelemetry-specification
3 participants
@jsuereth @arminru @haddasbronfman