Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sampler.shutdown #1295

Open
anuraaga opened this issue Dec 17, 2020 · 1 comment
Open

Add Sampler.shutdown #1295

anuraaga opened this issue Dec 17, 2020 · 1 comment
Labels
area:sampling Related to trace sampling area:sdk Related to the SDK release:after-ga Not required before GA release, and not going to work on before GA spec:trace Related to the specification/trace directory

Comments

@anuraaga
Copy link
Contributor

What are you trying to achieve?

We have TracerProvide.shutdown to allow a top-level entrypoint to shutdown all parts of the tracing SDK. However, we only have shutdown on span processors and exporters, but Sampler, where it is relatively common to have versions that fetch config from a remote source and need to be closed properly, does not. If we want the top-level entrypoint to be able to close all parts of the tracing SDK, Sampler also needs a shutdown method.

Additional context.

Related discussion on the desire for a top-level shutdown: #1288
@anuraaga anuraaga added the spec:trace Related to the specification/trace directory label Dec 17, 2020
@anuraaga anuraaga mentioned this issue Dec 17, 2020
Closed
@Oberon00 Oberon00 added area:sdk Related to the SDK release:after-ga Not required before GA release, and not going to work on before GA labels Dec 17, 2020
@Oberon00
Copy link
Member

Marked after-ga as per #1288 (comment)

@Oberon00 Oberon00 added the area:sampling Related to trace sampling label Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:sampling Related to trace sampling area:sdk Related to the SDK release:after-ga Not required before GA release, and not going to work on before GA spec:trace Related to the specification/trace directory
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anuraaga @Oberon00