Skip to content

Add Sampler.shutdown #1295

Open
Open
@anuraaga

Description

What are you trying to achieve?

We have TracerProvide.shutdown to allow a top-level entrypoint to shutdown all parts of the tracing SDK. However, we only have shutdown on span processors and exporters, but Sampler, where it is relatively common to have versions that fetch config from a remote source and need to be closed properly, does not. If we want the top-level entrypoint to be able to close all parts of the tracing SDK, Sampler also needs a shutdown method.

Additional context.

Related discussion on the desire for a top-level shutdown: #1288

Metadata

Assignees

No one assigned

    Labels

    area:samplingRelated to trace samplingarea:sdkRelated to the SDKrelease:after-gaNot required before GA release, and not going to work on before GAspec:traceRelated to the specification/trace directory

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions