Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define Aggregator Requirements in Metric SDK Spec #1260

Closed
shovnik opened this issue Nov 24, 2020 · 2 comments
Closed

Define Aggregator Requirements in Metric SDK Spec #1260

shovnik opened this issue Nov 24, 2020 · 2 comments
Assignees
Labels
area:sdk Related to the SDK priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:metrics Related to the specification/metrics directory

Comments

@shovnik
Copy link

shovnik commented Nov 24, 2020

What are you trying to achieve?

The Aggregator Functional Requirements are currently marked as ‘TODO’ in the metrics SDK spec. Will these requirements clearly define the aggregations each type of Aggregator is responsible for maintaining or is that left up to the interpretation of each language SDK.

The reason I am bringing this up is that I noticed that the Histogram aggregator in the Python SDK (https://github.com/open-telemetry/opentelemetry-python/blob/master/opentelemetry-sdk/src/opentelemetry/sdk/metrics/export/aggregate.py#L144) maintains only histogram buckets while the one in the Go SDK (https://github.com/open-telemetry/opentelemetry-go/blob/master/sdk/metric/aggregator/histogram/histogram.go#L47) maintains histogram buckets, total count and total sum. The total sum cannot be derived from histogram buckets, which means the same aggregator does not necessarily provide the exact same information across language SDKs currently. Overall, since the specification doesn’t exist today, there is an inconsistency in how specific aggregators are being implemented in the language SDKs.

When will these details be clarified in the spec?

cc- @alolita

@shovnik shovnik added the spec:metrics Related to the specification/metrics directory label Nov 24, 2020
@andrewhsu andrewhsu added priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA area:sdk Related to the SDK labels Dec 1, 2020
@jmacd jmacd removed their assignment Feb 4, 2021
@reyang reyang added this to the Metrics API/SDK Feature Freeze milestone Mar 3, 2021
@reyang
Copy link
Member

reyang commented Jul 6, 2021

@victlu assigned this to you based on the discussion at 07/01/2021 Metrics SIG.

Here are the breakdown:

@victlu
Copy link
Contributor

victlu commented Jul 7, 2021

I'm working on #1804

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk Related to the SDK priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

No branches or pull requests

5 participants