Skip to content

Commit

Permalink
Clarify that exemplar reservoir default may change in a minor version (
Browse files Browse the repository at this point in the history
…#3943)

Related to #3756. 

See this
[conversation](#3870 (comment))
for context.

---------

Co-authored-by: Reiley Yang <reyang@microsoft.com>
  • Loading branch information
jack-berg and reyang authored Mar 20, 2024
1 parent 032213c commit 7145a5d
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ release.

### Metrics

- Clarify that exemplar reservoir default may change in a minor version.
([#3943](https://github.com/open-telemetry/opentelemetry-specification/pull/3943))

### Logs

- Refine description of Instrumentation Scope.
Expand Down
5 changes: 5 additions & 0 deletions specification/metrics/sdk.md
Original file line number Diff line number Diff line change
Expand Up @@ -1052,6 +1052,11 @@ use `AlignedHistogramBucketExemplarReservoir`.
twenty (e.g. `min(20, max_buckets)`).
- All other aggregations will use `SimpleFixedSizeExemplarReservoir`.

Exemplar default reservoirs MAY change in
a [minor version bump](./../versioning-and-stability.md#minor-version-bump). No
guarantees are made on the shape or statistical properties of returned
exemplars.

#### SimpleFixedSizeExemplarReservoir

This reservoir MUST use an uniformly-weighted sampling algorithm based on the
Expand Down

0 comments on commit 7145a5d

Please sign in to comment.