Skip to content

Commit

Permalink
Clarify the trace SDK should log discarded events and links (#4064)
Browse files Browse the repository at this point in the history
  • Loading branch information
MrAlias authored May 31, 2024
1 parent f3aeadb commit 31e3af5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ release.

### Traces

- Clarify the trace SDK should log discarded events and links.
([#4064](https://github.com/open-telemetry/opentelemetry-specification/pull/4064))

### Metrics

### Logs
Expand Down
2 changes: 1 addition & 1 deletion specification/trace/sdk.md
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,7 @@ public final class SpanLimits {
* `AttributePerLinkCountLimit` (Default=128) - Maximum allowed attribute per span link count;

There SHOULD be a message printed in the SDK's log to indicate to the user
that an attribute was discarded due to such a limit.
that an attribute, event, or link was discarded due to such a limit.
To prevent excessive logging, the message MUST be printed at most once per
span (i.e., not per discarded attribute, event, or link).

Expand Down

0 comments on commit 31e3af5

Please sign in to comment.