Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): revert MSRV to 1.49 #827

Merged
merged 2 commits into from
Jun 29, 2022
Merged

Conversation

TommyCpp
Copy link
Contributor

  • remove const generic in order_map
  • replace ishac with hyper in zipkin's doc example. ishac currently has a dependency that requires 1.54 MSRV
  • Update CI

@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #827 (d70f6f4) into main (b5c3ec6) will increase coverage by 0.0%.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #827   +/-   ##
=====================================
  Coverage   69.8%   69.8%           
=====================================
  Files        111     111           
  Lines       9196    9196           
=====================================
+ Hits        6421    6427    +6     
+ Misses      2775    2769    -6     
Impacted Files Coverage Δ
opentelemetry-api/src/lib.rs 100.0% <ø> (ø)
opentelemetry-api/src/trace/order_map.rs 64.2% <ø> (ø)
opentelemetry-jaeger/src/lib.rs 92.5% <ø> (ø)
opentelemetry-zipkin/src/lib.rs 100.0% <ø> (ø)
opentelemetry/src/lib.rs 100.0% <ø> (ø)
opentelemetry-jaeger/src/exporter/mod.rs 54.0% <0.0%> (+3.0%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5c3ec6...d70f6f4. Read the comment docs.

@TommyCpp TommyCpp marked this pull request as ready for review June 28, 2022 14:07
@TommyCpp TommyCpp requested a review from a team June 28, 2022 14:07
@TommyCpp TommyCpp merged commit 103ed3a into open-telemetry:main Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants