Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semantic conventions to v1.10.0 #789

Closed
wants to merge 1 commit into from
Closed

Update semantic conventions to v1.10.0 #789

wants to merge 1 commit into from

Conversation

jakelee8
Copy link

No description provided.

@jakelee8 jakelee8 requested a review from a team April 29, 2022 20:19
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 29, 2022

CLA Not Signed

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #789 (980d28b) into main (02e15b2) will decrease coverage by 0.0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            main    #789     +/-   ##
=======================================
- Coverage   70.2%   70.1%   -0.1%     
=======================================
  Files        109     109             
  Lines       8963    8974     +11     
=======================================
+ Hits        6293    6299      +6     
- Misses      2670    2675      +5     
Impacted Files Coverage Δ
opentelemetry-datadog/src/exporter/mod.rs 24.1% <0.0%> (-0.3%) ⬇️
opentelemetry-zipkin/src/exporter/mod.rs 0.0% <0.0%> (ø)
opentelemetry-zipkin/src/exporter/uploader.rs 0.0% <0.0%> (ø)
opentelemetry-jaeger/src/exporter/collector.rs 19.8% <0.0%> (+0.8%) ⬆️
opentelemetry-jaeger/src/exporter/config/mod.rs 76.0% <0.0%> (+1.0%) ⬆️
opentelemetry-dynatrace/src/metric.rs 72.9% <0.0%> (+1.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02e15b2...980d28b. Read the comment docs.

@jakelee8 jakelee8 marked this pull request as draft April 29, 2022 21:33
@jtescher
Copy link
Member

jtescher commented May 1, 2022

Looks good 👍 , if you rebase off main the checks should pass.

Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to sign the CLA

@jakelee8 jakelee8 closed this Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants