Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove StatusCode::as_str #741

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Conversation

jtescher
Copy link
Member

The spec does not define a string representation, this was a jaeger-specific conversion.

The spec does not define a string representation, this was a
jaeger-specific conversion.
@jtescher jtescher requested a review from a team February 21, 2022 21:53
@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #741 (517f8bd) into main (5f1bd35) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #741      +/-   ##
==========================================
- Coverage   70.49%   70.46%   -0.04%     
==========================================
  Files         108      108              
  Lines        8755     8752       -3     
==========================================
- Hits         6172     6167       -5     
- Misses       2583     2585       +2     
Impacted Files Coverage Δ
opentelemetry-api/src/trace/span.rs 84.61% <ø> (+0.24%) ⬆️
opentelemetry-jaeger/src/exporter/mod.rs 59.76% <100.00%> (+0.09%) ⬆️
opentelemetry-sdk/src/metrics/controllers/push.rs 80.00% <0.00%> (-3.34%) ⬇️
...elemetry-sdk/src/metrics/aggregators/last_value.rs 42.30% <0.00%> (-0.83%) ⬇️
opentelemetry-sdk/src/metrics/aggregators/array.rs 32.09% <0.00%> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f1bd35...517f8bd. Read the comment docs.

@jtescher jtescher merged commit 354c83f into open-telemetry:main Feb 21, 2022
@jtescher jtescher deleted the remove-code-as-str branch February 21, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants