fix: re-export WithContext in the same place #2879
Merged
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2879 +/- ##
=====================================
Coverage 81.0% 81.0%
=====================================
Files 125 125
Lines 23945 23945
=====================================
Hits 19413 19413
Misses 4532 4532 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bantonsson
approved these changes
Mar 28, 2025
cijothomas
approved these changes
Mar 28, 2025
gruebel
approved these changes
Mar 29, 2025
…ix/re-export-withcontext
@cijothomas I believe you want to do a 0.29.1 with 0.29.0 plus only this fix cherry-picked, so I've added CHANGELOG notes accordingly. LMK if this isn't what you had in mind! |
|
@scottgerring it seems that there was a problem running the tests (they ran for 360min wow haha) |
cijothomas
added a commit
to cijothomas/opentelemetry-rust
that referenced
this pull request
Apr 1, 2025
Co-authored-by: Cijo Thomas <cijo.thomas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2862
0.29 maintained
with_context, the helper method, but notWithContextthe wrapper itself. Some customers may use this directly, and we can re-export it.For the particular use case identified in #2862 I offered a suggestion that likely avoids the need to depend on this type directly. I've opened this PR out of an abundance of caution, so we have something we can merge back in and potentially do a point release if we want to restore previous behaviour.
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes