-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: run clippy on features separately to find issues #2866
ci: run clippy on features separately to find issues #2866
Conversation
397dc97
to
4699440
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2866 +/- ##
=======================================
- Coverage 80.8% 80.8% -0.1%
=======================================
Files 124 124
Lines 23833 23836 +3
=======================================
Hits 19280 19280
- Misses 4553 4556 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
info: component 'clippy' for target 'x86_64-unknown-linux-gnu' is up to date @bantonsson Can you check this log from the CI run and see if this is to be fixed |
1ccf589
to
ae3d68e
Compare
@cijothomas The |
lint is now ~6-7 mins, previously ~3 mins. |
f5663a3
to
3a2e6fe
Compare
So what is the process for getting this merged when it's been approved? |
3a2e6fe
to
c8d7a99
Compare
@@ -19,7 +19,7 @@ opentelemetry_sdk = { path = "../../opentelemetry-sdk", features = ["rt-tokio"] | |||
opentelemetry-stdout = { workspace = true, features = ["trace"] } | |||
prost = { workspace = true } | |||
tokio = { workspace = true, features = ["full"] } | |||
tonic = { workspace = true, features = ["server", "codegen", "channel", "prost"] } | |||
tonic = { workspace = true, features = ["server", "codegen", "channel", "prost", "router"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, while this PR was waiting, a change missing this landed in main
and wasn't caught by CI.
https://github.com/open-telemetry/opentelemetry-rust/blob/main/CONTRIBUTING.md#how-to-get-prs-merged |
Changes
This runs
clippy
on features separately to ensure that the code doesn't rely on other features being enabled.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes