-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Modify example to use logs, baggage #2855
docs: Modify example to use logs, baggage #2855
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2855 +/- ##
=====================================
Coverage 80.9% 80.9%
=====================================
Files 124 124
Lines 23726 23726
=====================================
Hits 19200 19200
Misses 4526 4526 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor lints and some questions!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Eventually, I expect that we should just need one example (or two - one for console apps, and one web app) that'd showcase each signals. This PR enhances the existing web examples to also use logs. It also showcases Baggage and composite propagators.
Only a small step - expecting many more changes to this examples next