Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Modify example to use logs, baggage #2855

Merged
merged 8 commits into from
Mar 26, 2025

Conversation

cijothomas
Copy link
Member

Eventually, I expect that we should just need one example (or two - one for console apps, and one web app) that'd showcase each signals. This PR enhances the existing web examples to also use logs. It also showcases Baggage and composite propagators.
Only a small step - expecting many more changes to this examples next

@cijothomas cijothomas requested a review from a team as a code owner March 23, 2025 19:33
Copy link

codecov bot commented Mar 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.9%. Comparing base (e9b27a4) to head (1d9cc2b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2855   +/-   ##
=====================================
  Coverage   80.9%   80.9%           
=====================================
  Files        124     124           
  Lines      23726   23726           
=====================================
  Hits       19200   19200           
  Misses      4526    4526           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@scottgerring scottgerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor lints and some questions!

@cijothomas cijothomas requested a review from scottgerring March 24, 2025 15:18
Copy link
Contributor

@scottgerring scottgerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cijothomas cijothomas merged commit f12833f into open-telemetry:main Mar 26, 2025
22 checks passed
@cijothomas cijothomas deleted the cijothomas/example-fix branch March 26, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants