Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple processor to integration test #2522

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

cijothomas
Copy link
Member

No description provided.

@cijothomas cijothomas requested a review from a team as a code owner January 17, 2025 00:21

fn logs_simple_non_tokio_helper() -> Result<()> {
// Initialize the logger provider inside a tokio runtime
// as this allows tonic client to capture the runtime,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for reqwest-blocking, this can work without outside tokio too, will add a test to cover that also in a follow up PR.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.9%. Comparing base (27410b0) to head (bc1e600).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2522   +/-   ##
=====================================
  Coverage   77.9%   77.9%           
=====================================
  Files        123     123           
  Lines      22944   22944           
=====================================
  Hits       17880   17880           
  Misses      5064    5064           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@utpilla utpilla added the integration tests Run integration tests label Jan 17, 2025
@cijothomas cijothomas merged commit dace0ca into open-telemetry:main Jan 17, 2025
23 checks passed
@cijothomas cijothomas deleted the cijothomas/int-test-simple branch January 17, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration tests Run integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants