Directly implement Measure trait for metric aggregates #2371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2371 +/- ##
=====================================
Coverage 76.8% 76.8%
=====================================
Files 122 122
Lines 21823 21851 +28
=====================================
+ Hits 16772 16797 +25
- Misses 5051 5054 +3 ☔ View full report in Codecov by Sentry. |
fraillt
force-pushed
the
directly-implement-measure-trait
branch
from
00bee01 to
ea75ca6
Compare
fraillt
force-pushed
the
directly-implement-measure-trait
branch
from
ea75ca6 to
e939d1a
Compare
cijothomas
reviewed
Dec 18, 2024
| pub(crate) fn apply(&self, attrs: &[KeyValue], run: impl FnOnce(&[KeyValue])) { | ||
| if let Some(filter) = &self.filter { | ||
| let filtered_attrs: Vec<KeyValue> = | ||
| attrs.iter().filter(|kv| filter(kv)).cloned().collect(); |
There was a problem hiding this comment.
filtering is supposed to help reduce cost (including perf cost), but unfortunately, filtering path need heap allocations. Nothing introduced in this PR, but just mentioning as something we can fix in the future.
cijothomas
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for #2328
This PR is similar to #2425, but it's for measurement instead of collection.
Changes
AttributeSetFilterutility that (depending on provided filtering function) applies filter to attribute-sets before measurement. Similar logic as inAggregateBuilder::filterAttributeSetFilteras part of aggregateMeasuretrait.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes