Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/metric exporters non plural #2255

Merged

Conversation

pitoniak32
Copy link
Contributor

related to comment: #2221 (comment)

Changes

De-pluralize MetricExporter types:

  • MetricsExporter{Builder} -> MetricExporter{Builder}
  • InMemoryMetricsExporter{Builder} -> InMemoryMetricExporter{Builder}
  • PushMetricsExporter -> PushMetricExporter

As I was making these changes I noticed that there is also InMemoryLogsExporter and LogExporter. Will open another PR to address this.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@pitoniak32 pitoniak32 requested a review from a team as a code owner October 26, 2024 14:34
@pitoniak32
Copy link
Contributor Author

@lalitb - PR that addresses your comment #2241 (comment) about MetricsExporter

@pitoniak32 pitoniak32 force-pushed the refactor/metric-exporters-non-plural branch 2 times, most recently from c4518e0 to 2532bca Compare October 26, 2024 14:39
Copy link

codecov bot commented Oct 26, 2024

Codecov Report

Attention: Patch coverage is 34.88372% with 28 lines in your changes missing coverage. Please review.

Project coverage is 79.4%. Comparing base (afc8ff5) to head (873756f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-otlp/src/metric.rs 0.0% 14 Missing ⚠️
opentelemetry-stdout/src/metrics/exporter.rs 0.0% 7 Missing ⚠️
opentelemetry-otlp/src/exporter/http/mod.rs 0.0% 2 Missing ⚠️
opentelemetry-otlp/src/exporter/tonic/mod.rs 0.0% 2 Missing ⚠️
...etry-sdk/src/testing/metrics/in_memory_exporter.rs 71.4% 2 Missing ⚠️
opentelemetry-sdk/src/metrics/mod.rs 87.5% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2255   +/-   ##
=====================================
  Coverage   79.4%   79.4%           
=====================================
  Files        121     121           
  Lines      20962   20962           
=====================================
  Hits       16656   16656           
  Misses      4306    4306           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pitoniak32 pitoniak32 force-pushed the refactor/metric-exporters-non-plural branch from 2532bca to c1d2f0f Compare October 26, 2024 14:48
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We need to consolidate the changelog entries and make a separate migration guide, as there are quite a few changes for the next release.

@cijothomas cijothomas merged commit 17f4627 into open-telemetry:main Oct 28, 2024
23 of 25 checks passed
@pitoniak32 pitoniak32 deleted the refactor/metric-exporters-non-plural branch November 17, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants