Skip to content

Conversation

@cijothomas
Copy link
Member

Fixes #
Design discussion issue (if applicable) #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@cijothomas cijothomas requested a review from a team July 13, 2024 01:23
@codecov
Copy link

codecov bot commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.9%. Comparing base (6207882) to head (85a676e).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1932   +/-   ##
=====================================
  Coverage   74.9%   74.9%           
=====================================
  Files        122     122           
  Lines      20308   20308           
=====================================
+ Hits       15216   15217    +1     
+ Misses      5092    5091    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit cdf5f03 into open-telemetry:main Jul 13, 2024
@cijothomas cijothomas deleted the cijothomas/24release branch July 13, 2024 03:47
@djc
Copy link
Contributor

djc commented Jul 13, 2024

I can't find any mention in this PR or any open issues about the plan for the actual release (that is, publishing the crates to crates.io). Is it intentional that this hasn't been done yet?

@TommyCpp
Copy link
Contributor

@cijothomas let's hold off releasing until this is addressed?

Is it intentional that this hasn't been done yet?

I think it's just we haven't tag and done the release yet

@cijothomas
Copy link
Member Author

@cijothomas let's hold off releasing until this is addressed?

Is it intentional that this hasn't been done yet?

I think it's just we haven't tag and done the release yet

Correct. I was about to do it, but will wait until we revert the change that'll break tracing-opentelemetry.

Thanks @djc for raising this before we hit the release button!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants