Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade codecov/codecov-action from v3 to v4 #1728

Merged
merged 3 commits into from
May 9, 2024

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented May 9, 2024

Changes

codecov action has been failing for some time for coverage upload as here , which made us to not fail the CI in case of this error:

[2024-05-09T01:03:01.791Z] ['info'] Processing /home/runner/work/opentelemetry-rust/opentelemetry-rust/lcov.info...
[2024-05-09T01:03:01.797Z] ['info'] Processing /home/runner/work/opentelemetry-rust/opentelemetry-rust/.github/codecov.yaml...
[2024-05-09T01:03:01.838Z] ['info'] Detected GitHub Actions as the CI provider.
[2024-05-09T01:03:02.270Z] ['info'] Pinging Codecov: https://codecov.io/upload/v4?package=github-action-3.1.6-uploader-0.7.3&token=*******&branch=remove-flaky-tests&build=9010678378&build_url=https%3A%2F%2Fgithub.com%2Fopen-telemetry%2Fopentelemetry-rust%2Factions%2Fruns%2F9010678378%2Fjob%2F24757118382&commit=ea21fee8da8d9ac418db48ce8124a5924b1f9473&job=CI&pr=1727&service=github-actions&slug=open-telemetry%2Fopentelemetry-rust&name=&tag=&flags=&parent=
[2024-05-09T01:03:02.487Z] ['error'] There was an error running the uploader: Error uploading to https://codecov.io: Error: There was an error fetching the storage URL during POST: 429 - {'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 14[37](https://github.com/open-telemetry/opentelemetry-rust/actions/runs/9010678378/job/24757118382?pr=1727#step:8:38)s.', code='throttled')}
[2024-05-09T01:03:02.488Z] ['info'] Codecov will exit with status code 0. If you are expecting a non-zero exit code, please pass in the `-Z` flag

upgrade to v4 seems to be fixing the issue and getting the code coverage report.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team May 9, 2024 06:39
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.3%. Comparing base (348ec9e) to head (a4270a5).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1728     +/-   ##
=======================================
+ Coverage   71.0%   71.3%   +0.3%     
=======================================
  Files        135     136      +1     
  Lines      20751   20799     +48     
=======================================
+ Hits       14746   14845     +99     
+ Misses      6005    5954     -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb lalitb marked this pull request as draft May 9, 2024 06:45
@lalitb lalitb changed the title test codeql coverage [Not for review] test codeql coverage May 9, 2024
@lalitb lalitb changed the title [Not for review] test codeql coverage [Not for review] test CI coverage upload May 9, 2024
@lalitb lalitb changed the title [Not for review] test CI coverage upload upgrade codecov/codecov-action from v3 to v4 May 9, 2024
@lalitb lalitb marked this pull request as ready for review May 9, 2024 06:57
@cijothomas cijothomas merged commit 431baf6 into open-telemetry:main May 9, 2024
20 checks passed
@TommyCpp
Copy link
Contributor

Errrr I don't think it worked?

@lalitb
Copy link
Member Author

lalitb commented May 10, 2024

@TommyCpp Where do you see the issue? There was one failure I saw in CI which was related to this bug, but the rerun was successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants