Add tests for tracing appender #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1415 +/- ##
=======================================
+ Coverage 57.3% 58.1% +0.7%
=======================================
Files 146 146
Lines 18184 18301 +117
=======================================
+ Hits 10434 10641 +207
+ Misses 7750 7660 -90 ☔ View full report in Codecov by Sentry. |
lalitb
approved these changes
Nov 30, 2023
TommyCpp
approved these changes
Nov 30, 2023
This was referenced Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracing-appender today has zero test coverage. This is adding the basic coverage. I am leveraging
InMemoryExporter, so this is more than unit tests and indirectly tests the Logging API/SDK as well.This should make it easier to review PRs like #1380 and #1394 as well.
Changes from #1402 was needed for the tests, so I included that into this PR as @psandana is waiting for Microsoft CLA. (I have messaged him in separately about this)