Skip to content

Conversation

hdost
Copy link
Contributor

@hdost hdost commented Jun 15, 2023

Using the Copyright holder of "The OpenTelemetry Authors" as recommended.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@hdost hdost requested a review from a team June 15, 2023 09:41
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.3 ⚠️

Comparison is base (e773f92) 50.7% compared to head (bbeb1fc) 50.5%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1112     +/-   ##
=======================================
- Coverage   50.7%   50.5%   -0.3%     
=======================================
  Files        165     168      +3     
  Lines      19808   19893     +85     
=======================================
+ Hits       10059   10060      +1     
- Misses      9749    9833     +84     

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Using the Copyright holder of "The OpenTelemetry Authors" as
recommended.

* Update the LICENSE Files Per the CNCF Guidelines:
  https://github.com/cncf/foundation/blob/main/copyright-notices.md#copyright-notices
* Don't add authors to Cargo.toml
  * Per [RFC 3052](https://rust-lang.github.io/rfcs/3052-optional-authors-field.html)
  * Remove from opentelemetry-proto.

Signed-off-by: Harold Dost <h.dost@criteo.com>
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
@TommyCpp TommyCpp merged commit 4bf6609 into open-telemetry:main Jun 16, 2023
@hdost hdost deleted the update-authors branch June 30, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants