Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus exporter: omit empty otel_scope_info and otel_target_info metrics #1282

Closed
dashpole opened this issue Oct 2, 2023 · 0 comments · Fixed by #1428
Closed

Prometheus exporter: omit empty otel_scope_info and otel_target_info metrics #1282

dashpole opened this issue Oct 2, 2023 · 0 comments · Fixed by #1428

Comments

@dashpole
Copy link

dashpole commented Oct 2, 2023

Description

otel_scope_info and target_info should now only be generated when scope attributes and resource attributes are non-empty.

From open-telemetry/opentelemetry-specification#3660:

Prometheus exporters SHOULD generate an Info-typed
metric named otel_scope_info for each Instrumentation Scope with non-empty
scope attributes.

In SDK Prometheus (pull) exporters, resource attributes SHOULD be converted to
a single target_info metric
if the resource is not empty;

@hdost hdost added this to the Metrics API and SDK Beta milestone Oct 25, 2023
hdost pushed a commit that referenced this issue Dec 6, 2023
Fixes #1282 

* omit otel_scope_info and otel_target_info metrics when scope
attributes and resource attributes are empty.
* Update `CHANGELOG.md`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants