Skip to content

chore: ConfiguratorPatch updates #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: ConfiguratorPatch updates #1845

wants to merge 2 commits into from
+144 −6

Conversation

kaylareopelle
Copy link
Contributor

  • Rename the files for metrics and logs to match the class configuration_patch.rb -> configurator_patch.rb
  • Add tests for the ConfiguratorPatch in the Logs SDK

@kaylareopelle
chore: Update configuration_patch file to class
98d8a13 
Previously, these files were named `configuration_patch`, but the class
is named ConfiguratorPatch.

Now, they both use "configurator"
@kaylareopelle
test: Add logs config patch tests
caba491
@kaylareopelle kaylareopelle force-pushed the configurator-patch-updates branch from 70d8844 to caba491 Compare May 14, 2025 18:26
@kaylareopelle kaylareopelle marked this pull request as ready for review May 14, 2025 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbogsany fbogsany Awaiting requested review from fbogsany fbogsany is a code owner

@mwear mwear Awaiting requested review from mwear mwear is a code owner

@robertlaurin robertlaurin Awaiting requested review from robertlaurin robertlaurin is a code owner

@dazuma dazuma Awaiting requested review from dazuma dazuma is a code owner

@ericmustin ericmustin Awaiting requested review from ericmustin ericmustin is a code owner

@arielvalentin arielvalentin Awaiting requested review from arielvalentin arielvalentin is a code owner

@ahayworth ahayworth Awaiting requested review from ahayworth ahayworth is a code owner

@plantfansam plantfansam Awaiting requested review from plantfansam plantfansam is a code owner

@robbkidd robbkidd Awaiting requested review from robbkidd robbkidd is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kaylareopelle